Skip to content

Add lock functionality to animation dockers

reinold rojas requested to merge reinoldrojas/krita:recorder-lock into master

Add lock functionality to the utility title bar used by the Animation Curves and Animation Timeline dockers

I used the KoDockWidgetTitleBar as an example for the changes and tried to keep the code the same as that.

Requested on KA here


Test Plan

  1. Enable the Animation timeline and Animation curves docker
  2. Click on the lock icon (observe the close and floating buttons are no longer visible)
  3. Try and move the docker outside the main window
  4. Close and reopen krita and see the lock status gets saved

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list,

Merge request reports