Skip to content

Fixed recorder export video duration updating

Ken Lo requested to merge kenlo/krita:fixed-recorder-export-video-duration into master

Fixed a bug where the Video duration at the bottom of the Export Timelapse dialog isn't updating when input fps is changed unless you change the clicked values of the two checkboxes below.

Test Plan

Enable the recorder docker, click record, draw anything and then press export. Changing the input fps and pressing enter/ or clicking on any other widget should change the video duration.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports