Skip to content

Fix extra whitespace before lock on util titlebar

reinold rojas requested to merge reinoldrojas/krita:reinoldrojas/animation-lock-spacing into master

Right now there is a little bit of extra whitespace to the left of the lock icon on the animation dockers. I think this is from incorrect sizing since all the other icons are size 22,22 looking at the animation dockers. Fixed by just setting it to the same size as other icons.

NOTE: I also tested changing the size of the float and close buttons but I think they look too large/weird like that compared to other dockers float/close icons

Test Plan

Enable animation timeline and observe there is minimal whitespace to the left of the lock icon.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Edited by reinold rojas

Merge request reports