Skip to content

475737: PNG - Prevent multiple color conversions

Rasyuqa A H (Kampidh) requested to merge rasyuqaa/krita:rasyuqaa/fix-png-conversion into master

This MR is an attempt to fix BUG: 475737

There were two color conversion happening when exporting F32 CMYKA to PNG, the first one is conversion to sRGB and the second one is conversion to desired depth (I16 or I8) thus triggering the glitch. I'm not quite sure what causes it though.. Here I tried to gather up the colorspace parameters and doing the conversion (if necessary) in one go instead.

Test Plan

  • Try exporting F32 CMYKA document to PNG and check if the glitches are fixed

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports