Skip to content

Fix crash when pasting font family in TextEditor

Igor Danilets requested to merge alamat/krita:alamat-484066-fix into master

Fix crash when pasting font family in TextEditor Problem: Pasting a new font famyly and hitting Save or Discard while the FontFamilyComboBox is still in editing focus crashes. After pasting font family, the font is also not applied until you press enter or change focus.

Solution: Write the validator of the font familyies. Validator is triggered whenever the text is changed (including pasting), and if font famyly is correct, the font changes immediately. So, there are no conditions that provoke a crash.

BUG:484066

Test Plan

(Tell us how to test the changes you made.)

Formalities Checklist

  • [*] I confirmed this builds.
  • [*] I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • [*] I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • [*] I made sure my code conforms to the standards set in the HACKING file.
  • [*] I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports