Skip to content

Fix automatic timelapse recording

Freya Lupen requested to merge freyalupen/krita:freyalupen/bug-482378 into master

Commit 760c32e7 added checks in RecorderWriterManager::setup() and setCanvas() that stop recording if they are called twice. Auto recording was calling setup() twice from RecorderDockerDock::setCanvas(), which is avoidable.

BUG:482378

However, there is another regression here. Opening another document triggers those new checks as well. This causes the first document to stop recording, seen by the REC dot not turning red, though the record button is still on.

Disabling these checks fixes this, but it still does not work correctly. Somehow, the second document's frames won't get saved, or one document's frames will get saved into both folders. (Needs further investigation...)

Test Plan

Fixed: Enable "Record automatically" in the Recorder, reopen the document. Recording should be on.

Not fixed: Open a document, enable recording. Open another document, then switch back to the first. Recording should be broken(!).

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports