Skip to content

Fix free transform inverted rotation when flipped over in perspective

Stuffins requested to merge stuffins/krita:fix-inverted-rotation into master

In the free transform tool, when the image is rotated past 90 degrees on the X or Y axis, controls for rotating along the Z axis get reversed.

I'll admit it took trial and error to figure out whether to use SC or P's determinant from KisTransformUtils::MatricesPack, but I figured it ought to be one or the other since the Z rotation is between them and those are the only two that can be negative.

Test Plan

Doodle something, enter free transform, confirm rotation works without getting inverted under combinations of both mirroring along axes and flipping in perspective.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
The following tests FAILED:
        229 - libs-ui-kis_dummies_facade_test (Failed)

but it also fails on master

  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list,

Merge request reports