Skip to content

Fix recording with more than one document

Freya Lupen requested to merge freyalupen/krita:freyalupen/fix-multidoc-recording into master

In commit 760c32e7, RecorderWriterManager::setCanvas() and setup() were changed to stop the writers, because config can't change while recording. However, it didn't restart the writers with the new config, or unenable recording, leaving the recorder in an inconsistent state where the writers are stopped but recording is still enabled in the docker.

This commit fixes it so that when the config changes, the writers get restarted with the new config, and recording continues.

This commit also fixes a mistake from commit a7f98137, to check whether the onRecordButtonToggled(true) for autorecord actually calls the setup functions or not. If recording was already on in another document, it won't call them, so they still need to be called by setCanvas.

Test Plan

  1. Open a document, turn on recording.
  2. Open another document.
  3. Switch back to the first document.
  4. Scribble on the document, see that the REC dot turns red and it actually records something.

B. Do the same with autorecording.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports