Skip to content

Make the per channel and cross channel filters work with python

Deif Lou requested to merge deiflou/krita:deiflou/per_channel_filter_python into master

Some time ago I made some changes so that changing properties of those filters worked in python, but I guess I didn't find all the corner cases. This tries to make it work. There are some threads in KA asking for this.

The main issue is that those filters just stored the curves and other data as objects without setting the properties. I changed it so that the properties are stored as well and also so that changing a property changes the c++ objects.

Test Plan

You have to set the “nTransfers” first in case it is 0 (may happen if the filter is created from scratch, not obtained from a filter layer) to the number of channels (8 for rgba + “all channels”, “hue”, “saturation” and “lightness”), and then set the curve parameters and the driver parameters (only in cross channel).

I'm pinging @grum who made the last thread in KA about this for testing.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Edited by Deif Lou

Merge request reports