Skip to content

Fixed issue on S24 ultra regarding S-pen settings when HiDPI is turned off.

Spencer Sawyer requested to merge spencersa/krita:master into master

On S24 ultra, the S-pen settings menu is unusable without this change. The QComboBoxes are smaller than the text that's inside of them and the QLabels get truncated.

Test Plan

Open Krita on Android, Turn off HiDPI if enabled (restart), Go to S-Pen settings menu

Open Krita on Android, Turn on HiDPI if disabled (restart), Go to S-Pen settings menu

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • [?] I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports