Skip to content

Fix color sampler in wrap around mode

Freya Lupen requested to merge freyalupen/krita:freyalupen/bug-478190 into master

Some paint devices don't support painting in wrap around mode, but they can still be sampled from, so bypass the supportsWraproundMode check when color sampling.

There's a similar workaround in KisFillPainter::fillRectNoCompose, but this still seems like a bit of a hack. I'm not sure if there's a better way to fix the underlying cause, whatever that is.

BUG:478190

Test Plan

Enable Wrap Around Mode, try to color sample from the 'copies' of the image with sampling set to "All Visible Layers", or on a File Layer.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
  • Does the patch add a user-visible feature? If yes, is there a documentation MR ready for it at Krita Documentation Repository?

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports