Skip to content

Fix UI font size on Android

Freya Lupen requested to merge freyalupen/krita:freyalupen/android-font-size into master

Krita attempts to modify the font size to make docker text smaller (KisUiFont::dockFont) and welcome page text larger (KisWelcomePageWidget::largerFont), but it expects the size to be in points, while Android may give it in pixels. So it only caused a warning (QFont::setPointSizeF: Point size <= 0 (-0.900000), must be greater than 0).

This fixes it to use the pixel size, making dockers more readable as more text can fit in the space. Note that it's possible to do the same using Krita's custom UI font setting, which always sets the point size.

Before: android-ui-font-size-before-document-fs8 After: android-ui-font-size-after-document-fs8

(Side note: the "This plugin does not support setting window opacity" warning comes from KisFloatingMessage::updateOpacity.)

Test Plan

Check the UI font size on Android without custom UI font enabled, it should be more like on other platforms.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
  • Does the patch add a user-visible feature? If yes, is there a documentation MR ready for it at Krita Documentation Repository?

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports