Skip to content

Clarify merge layer text

Ralek Kolemios requested to merge rkolemios/krita:ralekarts/clarify-merge-layers into master

Based on this thread on the forums.

Changes context menu behavior slightly so that when multiple layers are selected, the menu reads 'Merge Selected Layers' rather than 'Merge with Layer Below' to reduce confusion, clarify intention, and be more in line with industry standard wording.

Fixes #462831

Test Plan

Select one or more layers or groups and right click to make sure the menu is accurate.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
  • Does the patch add a user-visible feature? If yes, is there a documentation MR ready for it at Krita Documentation Repository?

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Edited by Ralek Kolemios

Merge request reports