Skip to content

Fix Python invalid escape sequence warnings

Freya Lupen requested to merge freyalupen/krita:freyalupen/bug-489526 into master

If Python finds a string with an invalid backslash escape such as '\*', it will throw a Syntax or Deprecation warning. In the future this will become an error. The fix is to use a raw string r'\*' instead, which won't attempt to interpolate the escape sequences in the regexes. (See re's documentation.)

BUG:489526

Test Plan

  1. Make sure there isn't any __pycache__, by deleting $BUILDROOT/_install/share/krita/pykrita before rebuild-installing, otherwise the warnings won't fire.
  2. Turn on the Python warnings env var in the terminal with export PYTHONWARNINGS=all or equivalent.
  3. Run Krita in the terminal and check for Python warnings on startup. There shouldn't be any coming from built-in plugins.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
  • Does the patch add a user-visible feature? If yes, is there a documentation MR ready for it at Krita Documentation Repository?

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports