Skip to content

491231: WebP: fix colorspace export issue when dithering is enabled

Rasyuqa A H requested to merge rasyuqaa/krita:rasyuqaa/webp-export-fix into master

BUG: 491231

I forgot to account that if dithering option is enabled, the color profile is already converted to RGBA. Thus it can trigger a crash when saving from other than RGBA color model. This patch fixes it by properly taking the color profile.

Ps.: I tested this patch prior to !2092 (merged) merging, since I currently unable to compile due to missing dependency on Qt5::QuickControls2.

Test Plan

Export WebP from non-RGBA document (eg. Lab) with dithering option enabled and see if it exports successfully.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
  • Does the patch add a user-visible feature? If yes, is there a documentation MR ready for it at Krita Documentation Repository?

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports