Skip to content

Fix original offsets not being accounted for when copying from another document

Ralek Kolemios requested to merge rkolemios/krita:ralekarts/fix-copy-from-other-document into master

BUG:490998

This patch should fix situations in which recentered layers copied from another document do not lose position relative to each other.

This only happened if the nodes would be entirely off-canvas if pasted in the second document.

Known bug: The copied layer(s) thumbnail may show two copies of the layers, one in the original position and one in the new position. This was present before this bugfix as well, so it's probably unrelated.

Test Plan

I don't have a direct plan of testing all possibilities, but I took one of my files with ~170 layers and groups and moved it a couple thousand pixels down, then copied it over to a new small document and the entire stack was copied and recentered correctly.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
  • Does the patch add a user-visible feature? If yes, is there a documentation MR ready for it at Krita Documentation Repository?

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports