Skip to content

Add ability of setting curve points as "corners" (take 2)

Deif Lou requested to merge deiflou/krita:deiflou/curve_corner_02 into master

Same as !2191 (merged) but uses a new approach to store the info in KisCubicCurve. Here the points are stored as a list of QPoints and a separated list of KisCubicCurvePointExtraInfo (which right now only has the corner flag as extra info) instead of the KisCubicCurvePoint which has the position and the corner flag inside.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
  • Does the patch add a user-visible feature? If yes, is there a documentation MR ready for it at Krita Documentation Repository?

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports