Skip to content

Minor fixes for the Workflow Buttons docker

Freya Lupen requested to merge freyalupen/krita:freyalupen/workflow-buttons-fixes into master

The Workflow Buttons's custom icon file dialog was supposed to allow .png and .svg, due to a mistake it only allowed the latter. But I see no reason to limit it to those, so I changed it to query QImageReader for supported filetypes.

I also capitalized the name of the docker from "Workflow buttons" to "Workflow Buttons" as that's how every other docker is capitalized.

The other change is to fix two harmless runtime warnings: Unknown property margins (the style sheet property is "margin", not "margins"), and Trying to convert empty KLocalizedString to QString. (avoid passing i18n() an empty string).

(I know, it would be nice if I was more proactive about testing MRs to catch things before they are merged instead of right afterward.)

Test Plan

The Workflow Buttons custom icon file dialog should allow picking any supported image type. The docker name should be capitalized. It shouldn't log any warnings.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
  • Does the patch add a user-visible feature? If yes, is there a documentation MR ready for it at Krita Documentation Repository?

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports