Skip to content

TIFF: Ignore resolution if set to 0

Freya Lupen requested to merge freyalupen/krita:freyalupen/bug-473090 into master

The TIFF code used a default resolution if it wasn't set at all, but didn't check if it was set and 0.

BUG:473090

Also, prevent KisImage resolution being set to 0, because it breaks the zoom level.

Finally, fix the minimum resolution in the Scale Image to match the number of decimal points (which had been changed at some point), so that the user can't set the resolution to 0 from there.

Test Plan

  • Open the file from the bug report, it should display properly with a default resolution of 100ppi and not complain WARNING: Zoom is not isotropic! scaleX = nan scaleY = nan qFuzzyCompare(scaleX, scaleY) = false
  • Open the Scale Image dialog and the minimum resolution should be .01 instead of 0.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
  • Does the patch add a user-visible feature? If yes, is there a documentation MR ready for it at Krita Documentation Repository?

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports