Skip to content

CPMT: Include all possible language names; select best candidate country/region

Alvin Wong requested to merge alvinwong/krita:comics-mgr-locale-list into master
  • Change the CPMT language list to list all language names including regional variations. See following screenshots.
    • We list all names instead of using a region-agnostic name because there is no reasonable way to do that without attaching a "script" tag, and a language may support multiple scripts.
  • After choosing a language, automatically select the best candidate country/region, for example:
    • When current locale is zh_HK, selecting zh will automatically select HK. It was already working this way before this MR, but it was only applied when the dialog is first shown when creating a new project, not when you change the language selection and back.
    • When current locale is not English, selecting en will automatically select US, instead of the first item (001, which is confusing).

This is more of a temporary workaround until we have a better language selection widget to replace it.

Originally reported on kde-i18n-doc.

Screenshots

圖片 圖片

Test Plan

  • Open Comics Manager
  • Create new project
  • Check the language combobox

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
  • Does the patch add a user-visible feature? If yes, is there a documentation MR ready for it at Krita Documentation Repository?

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports