Skip to content

475020: Fix wrong thumbnail in "Save New Brush Preset" after "Switch to Previous Preset" shortcut

D Kang requested to merge exhaustor/krita:exhaustor/brush-edit-thumbnail into master

[BUG: 475020](https://bugs.kde.org/show_bug.cgi?id=475020)

Normally, when saving a new brush preset from the brush editor, the selected brush's thumbnail is used as the thumbnail for the new brush. However, after using the "Switch to Previous Preset" shortcut, the brush editor will use the thumbnail from the previous brush instead.

When a new preset is selected by the cursor, 'm_presetImage' in 'KisScratchPad' is changed to the new selected preset's thumbnail image. To stay consistent with this behavior, I added a line to update 'm_presetImage' in the same way when 'KisPaintopBox::slotSwitchToPreviousPreset' is called.

Test Plan

From the bug report:

1. Select two brushes in the brush menu.

2. Use the 'Switch to Previous Preset" shortcut.

3. Go to the brush editor and try saving the brush.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
  • Does the patch add a user-visible feature? If yes, is there a documentation MR ready for it at Krita Documentation Repository?

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports