Skip to content

459726: Add painting shortcuts to bezier curve and freehand path

D Kang requested to merge exhaustor/krita:exhaustor/brush-size-shortcut into master

BUG: 459726

The shortcuts for changing brush size and rotating brush tips don't work in the bezier curve and freehand path tools. The original bug is about the brush size shortcuts and bezier tool only, but I thought it made more sense to add the changes to both brushes and make all of the actions in KisPaintToolFactoryBase available. The actions affected are: increase brush size, decrease brush size, rotate brush tip clockwise, rotate brush tip counterclockwise, rotate brush tip clockwise precise, and rotate brush tip counterclockwise precise.

Test Plan

  1. Choose a brush with an asymmetrical tip and select the bezier curve or freehand path tool.
  2. Try all the shortcuts listed and verify the resulting stroke has both the brush tip angle and size expected.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
  • Does the patch add a user-visible feature? If yes, is there a documentation MR ready for it at Krita Documentation Repository?

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Edited by D Kang

Merge request reports

Loading