Skip to content

Fix pixel-perfect smoothing action

Freya Lupen requested to merge freyalupen/krita:freyalupen/pixel-smoothing-action-fixes into master

There was some mixup between a copy of the simple smoothing action and the pixel-perfect smoothing action, which caused warnings

QObject::connect: Cannot connect (nullptr)::triggered() to KisSignalMapper::map()
QObject::connect: Cannot connect (nullptr)::destroyed() to KisSignalMapper::_q_senderDestroyed()

The smoothing combobox order and enum order are expected to match for remembering the selected option. Which means pixel must be last unless that is refactored (since the existing order should not be changed).

Plus some code simplification.

Test Plan

  • In the Freehand Brush Tool Tool Options, switch Brush Smoothing to Pixel or Stabilizer and restart Krita, it should be remembered correctly.
  • Using a shortcut forBrush Smoothing: Basic should work again.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
  • Does the patch add a user-visible feature? If yes, is there a documentation MR ready for it at Krita Documentation Repository?

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports