Skip to content

JPEG XL: Fix potential lockup when loading multi-page images

Rasyuqa A H requested to merge rasyuqaa/krita:rasyuqaa/jpegxl-fix-multipage-import into master

A multi-page, animated JXL image (with frame duration set at 0xFFFFFFFF), can cause a deadlock when loaded in Krita. This MR tries to fix this by setting the aforementioned frame duration to 1 instead, so all frames (from all pages) can be loaded.

Also fix some values in advanced export options to correctly reflect with libjxl API docs (Modular encoding and Group order)

Test Plan

Multi-page image test: plot-multipage.jxl

  • Verify if that image is loaded correctly (all 5 frames loaded in timeline)

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
  • Does the patch add a user-visible feature? If yes, is there a documentation MR ready for it at Krita Documentation Repository?

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports