Skip to content

Insert the gamut mask toolbar into the wide gamut color selector.

Wolthera van Hövell requested to merge woltherav/krita:wdg-add-gamut-toolbar into master

I inserted the gamut toolbar into the wide gamut docker. It mostly fits nicely in the little hole between the patches and the quick settings menu. It however does look ugly when there's no mask selected.

I propose that we, instead of having the label that tells people to use the gamut docker, move all that into a tooltip that appears when artists press the gamut enable button (keeping it mobile friendly).

Note that I am not going to accept requests for UI perfection: there's no way to change gamut rotation without the advanced color selector, and I do want that thing gone eventually. It also doesn't fit inside the quick settings menu, simply because said menu covers the main selector whenever its open, so you can't see the rotation.

image

Test Plan

Check the wide gamut selector.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
  • Does the patch add a user-visible feature? If yes, is there a documentation MR ready for it at Krita Documentation Repository?

Merge request reports