Skip to content

WIP: Animation UI Changes and Fixes

Emmet O'Neill requested to merge (removed):ani/ui into master

(This will be a running branch for Eoin and I to push various smaller animation UI changes to, instead of doing a bunch of smaller MRs. Bigger changes will likely still happen in their own branches and MRs. Each change is going to be a single commit, so the branch will end up with multiple stand-alone commits that are merged to master in batches. But let us know if you'd all prefer that we don't do it this way.)

User interface changes so far:

  • "Show on Timeline" > "Pin to Timeline" in all contexts, as well as in the code. (To address confusion about terminology. BUG:407416)

  • Added a user setting for Auto-Pinning paint layers to the animation docker to general preferences > miscellaneous. (BUG:414690 BUG:413805)

Screenshot_from_2020-03-17_13-53-30

  • Added simple headers to Timeline context menus to mitigate accidental release clicks when working with a tablet. (BUG:413807)

  • Added additional details to the missing FFmpeg error message when rendering animations. (Scott mentioned that users frequently get stuck on ffmpeg setup, so I thought we might do better by directing them to the documentation from within the error message itself.)

Screenshot_from_2020-03-10_14-33-00

  • Changing layer color labels no longer recursively overwrites the color labels of child nodes. This prevents users from accidentally changing the colors of layers when coloring the containing group. (Hopefully addressing a problem that Bollebib was having.)

  • Frame change notifications. Setting in Configuration > Display

  • Activate sibling node actions. Optional shortcuts to navigate the node tree without traversing groups. Setting in Configuration > Shortcuts > Actions > Krita > Layers > "Activate sibling..."

  • Added a new KisLayerFilterWidget with support for filtering the layer tree by name and/or color label. (WIP: There are still a few glaring bugs left to fix.)

krita-layer-filter

Testing

Please test by interacting with the animation tools in as many ways as possible, including the Timeline Docker, the Animation Docker, and the Rendering Dialog. Let us know if you come across any bugs that we've missed, and feel free to give us general non-bug feedback on ways that you think the user experience of animation in Krita can be improved. =]

Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
Edited by Eoin O'Neill

Merge request reports