Skip to content

use begin|end|Insert|RemoveRows instead of resetting the model

Halla Rempt requested to merge rempt/resourcemodel_rewrite into master

Where the models would use beginResetModel() and endResetModel when rows were inserted or removed, the models will now use the finer-grained beginInsertRows/endInsertRows and beginRemoveRows and endRemoveRows.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
Edited by Halla Rempt

Merge request reports

Loading