Skip to content

Fix touch-based rotation and zoom on Wacom tablets.

P. Varet requested to merge pvaret/krita:pvaret/fix-wacom-zoom into master

Fix touch-based rotation and zoom on Wacom tablets.

Turns out the TouchPoints in a QTouchEvent are not always trustworthy, and we need to filter out situations where we can tell they are not reporting the correct coordinates.

BUG:421295

Test Plan

1/ Build.

2/ Plug in a Wacom Intuos Pro M or similar touch-enabled Wacom tablet. Be sure to set it to non-gesture mode so it sends raw multi-touch events.

3/ Run Krita, create a picture.

4/ Zoom and rotate it with two-fingers gestures.

5/ Observe that https://bugs.kde.org/show_bug.cgi?id=421295 no longer occurs.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports