Skip to content

Fonkle/krita/4.3/manage resources dialog bug (Needs review!)

Fred Fonkle requested to merge (removed):fonkle/krita/4.3/manage_resources_dialog_bug into master

The fix for this bug: https://bugs.kde.org/show_bug.cgi?id=423097 sadly does not fix the problem completely. Although the dialog is now correctly parented to the current MainWindow, the dialog still does not always position correctly. I have added a merge request with a fix.

It explicitly moves the dialog to the center of the supplied parent QRect.

Would you be so kind as to review it? Thanks!

Test Plan

Just open the Settings->Manage Resources dialog a million times I guess :).

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports