Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Krita
Krita
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
  • Merge Requests 50
    • Merge Requests 50
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • Graphics
  • KritaKrita
  • Merge Requests
  • !41

Merged
Opened Jun 11, 2019 by Tusooa Zhu@tusooaw🔼Developer4 of 6 tasks completed4/6 tasks

Snapshot Docker

  • Overview 24
  • Commits 21
  • Changes 34

This is a snapshot docker that allows users to create snapshots (shallow copies) of the current document, and switch back to any snapshot at a later time. Users can also edit the names of the snapshots or delete them in the docker.

Test Plan

  1. Create a document.
  2. Paint something.
  3. Add some guides.
  4. Add some assistants.
  5. Add some reference images.
  6. Add a document-wide palette by creating a palette in the palette docker and then click "edit this palette" then click "OK."
  7. Crop the image to a smaller size.
  8. Create a snapshot in the snapshot docker.
  9. Double click that snapshot to rename it.
  10. Restore the document to the initial state in the History Docker by clicking <empty>.

Everything in the document should return to the state before creating the snapshot.

TODO

  1. Assistants decoration needs to be updated correctly.
  2. We probably should use counts for snapshot names.
  3. [Disputable] Should undo stack be cleared, or should we add an undo command for switching snapshots? NO

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!) It breaks one more image test than master: kis_node_model_test.
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
Edited Jun 18, 2019 by Tusooa Zhu
Assignee
Assign to
Reviewer
Request review from
Krita 4.3
Milestone
Krita 4.3 (Past due)
Assign milestone
Time tracking
Reference: graphics/krita!41
Source branch: tusooaw/T10991-snapshot-docker