Skip to content

Add support for SIP v5 — version 2 of the MR

Dmitry Shachnev requested to merge dmitryshachnev/krita:sip5 into master

This is the second attempt to land SIP v5 support after !417 (merged) which got reverted.

Differences to !417 (merged): I restored FindSIP.py and kept the previous logic for SIP v4, while adding a new code path for SIP v5.

Test Plan

@rempt This should work on Windows, please test.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
    • I am asking for help here :) I guess the relevant tests are in plugins/python, how to run them?
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports