Skip to content

Streamline layout handling

Samuel Gaist requested to merge sgaist/krita:fix_layout_warnings_cxx into master

This merge request tries to streamline the way layouts are set on widgets.

In lots of places layouts are created with a parent and later on setLayout is called. This is redundant as passing a widget parent when creating a layout sets the layout directly on it.

Therefore, this merge request, as much as possible, uses the same technique everywhere.

Some areas have been refactored to make the code more readable.

This merge request only goes through the C++ parts. Another one will go through the Python parts.

Test Plan

The simplest way to test these changes is to use Krita as usual and see if any of the widgets looks is broken.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports