Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Krita Krita
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Bugzilla
    • Bugzilla
  • Merge requests 77
    • Merge requests 77
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • GraphicsGraphics
  • KritaKrita
  • Merge requests
  • !467

GSoC 2020: Enable live preview of Fill Layers

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Amy spark requested to merge lsegovia/krita:work/amyspark/fill-layer-preview into krita/4.3 Aug 13, 2020
  • Overview 12
  • Commits 3
  • Pipelines 0
  • Changes 10

This MR enables live previewing Fill Layers before confirming addition.

So far, this MR doesn't work -- the jobs have been successfully migrated, but they do not execute at all.

I'm grateful if anyone could have a look at it and help me go, one step at a time.

Plan

  • Remove use of KisGeneratorStrokeStrategy
  • Decouple update job generation from the delayed update/signal compressor timeout
  • Connect the Fill Layer generator dialog to the stroke and send the jobs over to the stroke

Test Plan

Add a Fill Layer, check it's instantly rendered.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

cc @dkazakov

Edited Aug 15, 2020 by Amy spark
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/amyspark/fill-layer-preview