Skip to content

365372 hsy color selector

Jasper Hartog requested to merge jasperh/krita:365372-hsy-color-selector into master

The HSY' color selectors, the color wheel, and the square, previously used an HSV color selector to select the color this is replaced by a new HSY' color selector configuration.

I'm still quite new to all the different color modes and don't know if it's now more correct than before, but hopes so. I still have a few questions regarding

  • Is it correct that the HSY' color selector has a different hue than all the other color selectors? HSY_color_selector
  • The Parameters name Hluma, I couldn't come up with a better name. But I don't know if this name correctly describes it's the function.
  • I added Hluma to the beginning of the enum, which may cause an incorrect configuration. Is this a problem? I asked this question a few days ago on IRC, and there I got the impression that it wasn't a problem.

Test Plan

  1. Set the Color Mode Type of the Advanced Color Selector to HSY' and choose one of the following color selectors with position 2 or 5, left to right, top to bottom.
  2. Draw a shape on the canvas with a saturated color, e.g. R: 245, G: 96, B: 0.
  3. Pick the color up with the Color Selector Tool.
  4. Click on the same position as the circle in the Advanced Color Selector.
  5. Draw over the previously drawn shape.

Result: Both colors should be the same.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

BUG:365372

Merge request reports