Skip to content

Make LCMS init() crash-proof

Agata Cacko requested to merge tymond/krita:tiar/lcms_make_init_crashproof into master

Before this commit, there was multiple cases when LcmsColorProfileContainer::init() could crash when reading the profile because cmsIsTag() returns true but cmsReadTag() returns a null pointer.

This commit checks all the pointers before dereferencing it.

CCBUG:423685

Test Plan

???

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
Edited by Agata Cacko

Merge request reports