Skip to content

Bugfix: Vector/references don't get rendered

Sharaf Zaman requested to merge szaman/krita:bug-422312-vectors-android into krita/4.3

KisExternalLayer had no key function, so the typeinfo was emitted as a weak symbol. So, it may not always be possible to merge the typeinfo with shared libraries. This would make dynamic_cast fail (because it depends on RTTI in this case).

src: https://android.googlesource.com/platform/ndk/+/master/docs/user/common_problems.md#rtti_exceptions-not-working-across-library-boundaries

Test Plan

Try opening and saving files (kra to name one) with vector objects or reference images. They should be rendered properly on Android.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports