Skip to content

426992 Fix translations lookup

Amy spark requested to merge lsegovia/krita:work/amyspark/426992-fix-translations-lookup into krita/4.4.0

This MR allows KisActionRegistry to look up translations with specific disambiguation contexts.

This is only part of the fix -- some strings will remain untranslated because, in the krita.po files, they are marked as fuzzy (unverified, autogenerated translations). The onus is on the i18n team to start marking them as correct. See section 2.5 in http://pology.nedohodnik.net/doc/user/en_US/ch-poformat.html.

CCBUG: 426992

Test Plan

Grab the tarball from 4.4.0 beta 2 and apply this patch. Then recompile and check that File > New... is translated properly.

If not, open the krita.po file for your language and check that this entry:

#. i18n: context: Action (file_new), Actions (File), ActionCollection (Menu)
#: krita/kritamenu.action:7
#, fuzzy, kde-format
#| msgid "New..."
msgctxt "New document"
msgid "&New..."
msgstr "Nouveau..."

is marked as fuzzy (as shown above). If it is (and should be), delete said format line, recompile and check again.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports