Skip to content

Parent QMessageBox to the active window

Sxnicdesu requested to merge (removed):sxnic/2-qmessagebox-parent into master

As requested by https://phabricator.kde.org/T8774 (Boud), All QMessageBox parent to the main window, making sure a second window doesn't pop up when a dialog appears.

This makes Krita feel more polished, after all.

Test Plan

Example:

  1. Open up Krita, and head for the option Reset Krita Configurations, located in Settings
  2. When the dialog appears, you can see that there is a <2> on the end of the dialog, and that there is only 1 instance open. Compared to version 4.3.0, which at that version, creates a new dialog instance, and the <2> doesn't show up on the dialog
  3. (Make sure to click no, because if you click yes, all your configurations will be lost)

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
Edited by Halla Rempt

Merge request reports