Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Krita Krita
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Bugzilla
    • Bugzilla
  • Merge requests 76
    • Merge requests 76
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • GraphicsGraphics
  • KritaKrita
  • Merge requests
  • !516

Give meaningful name to Drag And Drop File Layer (Bug#427235)

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Jonathan Colman requested to merge qchai/krita:qchai/named_drag_and_drop into master Oct 06, 2020
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 1

Set name in creation of KisFileLayer instance to the file name in the url path for local drag and drops, instead of the previous "File Layer #number". Thus, File Layers created via local drag and drops now have meaningful names.

Test Plan

Drag and drop an image from a directory on your machine onto the canvas and Insert as new File Layer. The file layer should be named after the filename of the image you dropped in.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: qchai/named_drag_and_drop