Skip to content

Fix color selection discrepancy on selecting a color with native dialog in macOS

Ivan Yossi requested to merge ivany/krita:407880_colorSelectDrift into master

We used a dumbConverterInstance to set the new coloe in the DualColorButton, this caused drift in colorspaces different than RGB-8bit system built-in. Now we use previous KoColor colorspace information to convert to QColor.

Test Plan

All color selectors make QColorDialog on macOs report the same color.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
Edited by Ivan Yossi

Merge request reports