Skip to content

Parenting more unparented KoDialog and QDialog instances

Sxnicdesu requested to merge (removed):sxnic/3-qdialog-parenting into master

This time, I gave the QDialog and KoDialog instances that did not have a parent, a parent to the main window. 「qApp->mainWindow()」 Dialogs that were changes are:

  • Filter configuration XML
  • Heightmap Import Options
  • JPEG 2000 Export Options
  • PDF Import Options

Test Plan

Unfortunately, I couldn't find a way to test all of the changes correctly, but I do know how to test the Filter configuration XML dialog box.

Steps:

  1. Open up a document
  2. Go to filter and pick any filter
  3. Once you see a box, click on XML. 「That box should be parented」

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports