Skip to content

Fix a crash during SVG to document conversion

Lucid Sunlight requested to merge awakening/krita:svg-to-doc-crash into master

If user forgets to separate property name and value with :, parser will crash when trying to access property value, as the string list now only holds 1 item, instead of expected 2.

Ignore the property instead of crashing.

Test Plan

  • Pick SVG text tool
  • Create a text object
  • Switch to SVG source
  • Remove : from one of the properties
  • Switch back to Rich text
  • Don't crash

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports