Skip to content

Similar color selection tool modernize

Agata Cacko requested to merge tymond/krita:tiar/similar_color_selection_tool_modernize into master

First commit: just add another option to the tool (it's already working) Second: make it multithreaded (in commands) Third: optimize

Problem in the MR:

  • Color Labeled Layers is restrained to the image bounds (in theory it's fine, since it's a new feature, but...)
  • Some solution: area inside the image bounds would be calculated in the optimized way as it is now, but later I could add one or more strokes that would just take care of the sides (it would be not 100% optimized but still much more than it is before this MR, and it would allow for calculating everything even outside of the image bounds).
  • Dmitry talked about some other way, but I'm not sure how to do it without leaving the applicator + commands as the way to approach multithreading (and I would prefer to keep it consistent between selection tools).

Test Plan

test file: conti_color_new_options_002.kra

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports