Skip to content

Upgrade macOS integration plugins

Amy spark requested to merge lsegovia/krita:work/amyspark/upgrade-macos-plugin into master

This MR brings a massive refactor to the existing plugins for macOS:

  • Adds QuickLook Thumbnailing (10.15+) support.
  • Adds Spotlight metadata support.
  • It drops NSTasks for reading the KRA file in favor of a bundled minizip library. NSTask is usable from QuickLook generators, but not from Spotlight (mdimporter/mdworker).
  • It adds license headers throughout the updated code, recognising the original authors of the Quicklook plugin.

The README and packaging scripts have been updated to reflect these changes. The LICENSE (GPLv2) has been removed to make it consistent with the rest of Krita; feel free to contact me if this is wrong.

CCMAIL: kimageshop@kde.org

Test Plan

Compile and deploy Krita, or use the following DMG(signature here, key at github).

Once deployed, check that the thumbnails are preserved, and that you now have plenty of metadata in the Finder.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports