Skip to content

Retain current text changes when saving settings

Lucid Sunlight requested to merge awakening/krita:bug-424213 into master

When applying settings, we trigger a switchTextEditorTab call, and if we happen to effectively switch to the same tab (Rich Text only <-> Both or saving without changing anything at all), we're losing changes we've made, as we're overwriting text document with whatever is in SVG editor and SVG editor is not updated when you make changes (or even save) in Rich Text mode.

So, just check if we already on the tab.


Test Plan

  • Create a text object
  • Make some change(s)
  • Open settings
  • Click OK without changing anything or switch editor mode
  • Retain changes

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports