Skip to content

Do not catch mouse events on the on-canvas message popups

Ghost User requested to merge (removed):mouse-events-canvas-popup into master

This merge request makes the on-canvas popup messages pass through mouse events to the canvas below. Fixes choppy zooming when people zoom right over the popup messages.

Test Plan

  1. Make sure the Settings -> General -> Window -> Show on-canvas popup messages checkbox is turned on.
  2. Open a new document.
  3. Move the mouse where the on-canvas popup messages appear.
  4. Zoom in an out with the mouse wheel. The popup message should not catch the mouse events anymore. The zooming should be responsive, not choppy as before. (before / after)

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports