Skip to content

Fix restoring docker locks

Lucid Sunlight requested to merge awakening/krita:docker-lock into master

We were reading from wrong configuration group when restoring locks, so everything was unlocked when opening Krita.

Toolbox had an issue being still movable, floatable and closeable despite being locked, removing setFeatures calls seemed to have fixed it.

And some clean up while I'm at it, formatting and removing unused code. Removed quite a bit of unused includes in KoToolDocker, at least unused on Linux, may come back to bite me when compiled on other platforms.

Test Plan

  • Open Krita
  • Open document
  • Lock a docker or two
  • Gracefully close and reopen Krita
  • Still have them locked

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports