Skip to content

Assorted AppImage build fixes

Amy spark requested to merge lsegovia/krita:work/amyspark/fix-appimage-anna-update into master

This MR derives from my work in !581 (merged). It fixes locally building AppImages in two ways:

  • it allows incremental rebuild of an AppImage by rsyncing directories instead of moving them, which is a no-no if there's an existing krita.appdir structure in the build root.
  • it fixes the AppImage packing step, by not setting update information if none is available. This is a case that wasn't checked in Anna's work.

cc @amedonosova

Test Plan

Build AppImages.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports