Skip to content

Android: fix app freeze problem caused by pop-up widgets

Sharaf Zaman requested to merge szaman/krita:bug-429636-app-freeze into master

Reason: If we double press KisPopupButton, for our first press we tell Qt to widget->show() which causes an internal flush of event queue then the second event is sent down which hides the widget.

The second event is immature because the actions of first event didn't complete in time. This makes the widget hidden while also grabbing mouse and keyboard, thus freezing the entire app.

Note: The bug is time sensitive.

BUG:429636

Test Plan

The bug is time sensitive. I was able to reproduce it with multiple different popup widgets, but most successfully with brush editor, byy quickly double tapping the popup button.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports