Skip to content

Improve design consistency for icons

Scott Petrovic requested to merge (removed):petrovic/flat-icons-toolbar into master

I had this thought a little while ago, and @kamathraghavendra brought this same design issue up recently...so I thought I would start a merge request/discussion.

Problem: With so many people working on the application, we are doing different things with the application style. One area that is getting a bit messy is how we display icons. Right now we seem to use two different ways to display them: borders and flat. See the difference with various UI elements.

icon-consistency

The green areas are one style, and the orange areas are one style. We don't necessarily have to do one style for everything, but we should decide what rules we might want to follow. For example we might want to make all the header icon flat, but then have it be ok to have the stuff inside have borders. If we completely remove the borders on headers, we might want to add extra spacers to areas that have drop-downs. The small patch I made so far looks like this for the application header.

toolbar-consistent

Test Plan

Start the application and try to make sure we have consistent rules for how we display icons

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
Edited by Scott Petrovic

Merge request reports